Rcsp new interface overloads - #538
Conversation
|
Boost dependency footprint vs Header-inclusion weights (graph files pulling each direct dependency in): No header-inclusion-weight changes. Transitive Boost modules: 68 → 68 (0) |
|
Compiler-warning counts vs
|
|
Hi @andreacassioli ! Looks good to me, great work! To tie it up, we would want to add deprecation notices on the old interfaces as mentioned in the previous conversation so users get a warning (note their position between template args and return type): #include <boost/config.hpp>
template < class Graph, class VertexIndexMap, class EdgeIndexMap, class Resource_Container, class Resource_Extension_Function, class Dominance_Function >
BOOST_DEPRECATED("edge_index_map is unused; drop it and call the 5-argument r_c_shortest_paths overload. Removal planned for Boost 1.95.")
void r_c_shortest_paths(const Graph& g, const VertexIndexMap& vertex_index_map, const EdgeIndexMap& edge_index_map, ...)
{
r_c_shortest_paths(g, vertex_index_map, s, t, ...);
}Old examples and test files should begin with a See demonstration here: https://godbolt.org/z/dYszsMaea I think it's reasonable to duplicate the unit tests and the example here (at the cost of blowing up the PR size but there it's a transient inconvenient). If you could quickly confirm locally that the old and new example generate the same output that would be gold! 🙏🏽 Let me know if you have any question, |
2 participants
Before submitting
developbranch.Type of change
Does this PR introduce a breaking change?
What this PR does
Motivation
The current interfaces expose a redundant parameter (edge index map)
The issue has been raised here #342
Testing
Checklist
b2in thetest/directory).